Skip to content

[WIP] Expand free alias types during variance computation #141030

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

[WIP] Expand free alias types during variance computation #141030

wants to merge 1 commit into from
+14 −55

Conversation

fmease
Copy link
Member

@fmease fmease commented May 15, 2025

Instead of computing variances for them since they can never be rigid anyway.

Fixes #140230.

@fmease fmease added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. T-types Relevant to the types team, which will review and decide on the PR/issue. F-lazy_type_alias `#![feature(lazy_type_alias)]` rla-silenced Silences rust-log-analyzer postings to the PR it's added on. labels May 15, 2025
@fmease fmease moved this to In Progress in Lazy Type Aliases (LTA) May 15, 2025
@fmease
Copy link
Member Author

fmease commented May 15, 2025

@bors try @rust-timer queue

@rust-timer

This comment has been minimized.

Sign in to view
@rustbot rustbot added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label May 15, 2025
bors added a commit to rust-lang-ci/rust that referenced this pull request May 15, 2025
@bors
Auto merge of rust-lang#141030 - fmease:lta-no-variance, r=<try>
1b77fcd 
[WIP] Expand free alias types during variance computation

Instead of computing variances for them since they can never be rigid anyway.

Fixes rust-lang#140230.
@bors
Copy link
Collaborator

bors commented May 15, 2025

⌛ Trying commit 1c11869 with merge 1b77fcd...

@bors
Copy link
Collaborator

bors commented May 15, 2025

☀️ Try build successful - checks-actions
Build commit: 1b77fcd (1b77fcd0847b6d6dcac3b0857fc0acc504e9f357)

@rust-timer

This comment has been minimized.

Sign in to view
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (1b77fcd): comparison URL.

Overall result: ❌ regressions - please read the text below

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR may lead to changes in compiler perf.

Next Steps: If you can justify the regressions found in this try perf run, please indicate this with @rustbot label: +perf-regression-triaged along with sufficient written justification. If you cannot justify the regressions please fix the regressions and do another perf run. If the next run shows neutral or positive results, the label will be automatically removed.

@bors rollup=never
@rustbot label: -S-waiting-on-perf +perf-regression

Instruction count

This is the most reliable metric that we have; it was used to determine the overall result at the top of this comment. However, even this metric can sometimes exhibit noise.

mean range count
Regressions ❌
(primary)		 1.1% [1.1%, 1.1%] 1
Regressions ❌
(secondary)		 0.7% [0.7%, 0.7%] 1
Improvements ✅
(primary)		 - - 0
Improvements ✅
(secondary)		 - - 0
All ❌✅ (primary) 1.1% [1.1%, 1.1%] 1

Max RSS (memory usage)

Results (primary 3.2%, secondary 5.0%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)		 3.2% [0.5%, 9.0%] 4
Regressions ❌
(secondary)		 5.0% [4.6%, 5.4%] 2
Improvements ✅
(primary)		 - - 0
Improvements ✅
(secondary)		 - - 0
All ❌✅ (primary) 3.2% [0.5%, 9.0%] 4

Cycles

Results (primary -0.8%, secondary -10.5%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)		 - - 0
Regressions ❌
(secondary)		 - - 0
Improvements ✅
(primary)		 -0.8% [-0.8%, -0.8%] 1
Improvements ✅
(secondary)		 -10.5% [-14.0%, -2.6%] 7
All ❌✅ (primary) -0.8% [-0.8%, -0.8%] 1

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 773.561s -> 773.719s (0.02%)
Artifact size: 365.44 MiB -> 365.31 MiB (-0.04%)

@rustbot rustbot added perf-regression Performance regression. and removed S-waiting-on-perf Status: Waiting on a perf run to be completed. labels May 15, 2025
@BoxyUwU BoxyUwU self-assigned this May 27, 2025
@fmease fmease force-pushed the lta-no-variance branch from 1c11869 to 9429c14 Compare July 10, 2025 15:38
@fmease
Copy link
Member Author

fmease commented Jul 10, 2025

@bors2 try @rust-timer queue

@rust-timer

This comment has been minimized.

Sign in to view
@rust-bors
Copy link

rust-bors bot commented Jul 10, 2025

⌛ Trying commit 9429c14 with merge f04a108…

To cancel the try build, run the command @bors2 try cancel.

rust-bors bot added a commit that referenced this pull request Jul 10, 2025
@rust-bors
Auto merge of #141030 - fmease:lta-no-variance, r=<try>
f04a108 
[WIP] Expand free alias types during variance computation

Instead of computing variances for them since they can never be rigid anyway.

Fixes #140230.
@rustbot rustbot added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Jul 10, 2025
@rust-bors
Copy link

rust-bors bot commented Jul 10, 2025

☀️ Try build successful (CI)
Build commit: f04a108 (f04a1083ef0335f753c2d52583e8cc33a34e95fb, parent: 119574f83576dc1f3ae067f9a97986d4e2b0826c)

@rust-timer

This comment has been minimized.

Sign in to view
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (f04a108): comparison URL.

Overall result: no relevant changes - no action needed

Benchmarking this pull request means it may be perf-sensitive – we'll automatically label it not fit for rolling up. You can override this, but we strongly advise not to, due to possible changes in compiler perf.

@bors rollup=never
@rustbot label: -S-waiting-on-perf -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results (primary -1.5%, secondary 1.4%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

mean range count
Regressions ❌
(primary)		 - - 0
Regressions ❌
(secondary)		 4.6% [3.1%, 6.1%] 2
Improvements ✅
(primary)		 -1.5% [-1.5%, -1.5%] 1
Improvements ✅
(secondary)		 -5.0% [-5.0%, -5.0%] 1
All ❌✅ (primary) -1.5% [-1.5%, -1.5%] 1

Cycles

Results (secondary 2.1%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

mean range count
Regressions ❌
(primary)		 - - 0
Regressions ❌
(secondary)		 2.1% [2.1%, 2.1%] 1
Improvements ✅
(primary)		 - - 0
Improvements ✅
(secondary)		 - - 0
All ❌✅ (primary) - - 0

Binary size

Results (secondary -0.0%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

mean range count
Regressions ❌
(primary)		 - - 0
Regressions ❌
(secondary)		 - - 0
Improvements ✅
(primary)		 - - 0
Improvements ✅
(secondary)		 -0.0% [-0.0%, -0.0%] 1
All ❌✅ (primary) - - 0

Bootstrap: 463.013s -> 463.287s (0.06%)
Artifact size: 374.51 MiB -> 374.53 MiB (0.01%)

@rustbot rustbot removed S-waiting-on-perf Status: Waiting on a perf run to be completed. perf-regression Performance regression. labels Jul 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@BoxyUwU BoxyUwU

Labels
F-lazy_type_alias `#![feature(lazy_type_alias)]` rla-silenced Silences rust-log-analyzer postings to the PR it's added on. S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. T-types Relevant to the types team, which will review and decide on the PR/issue.
Projects
Lazy Type Aliases (LTA)
Status: In Progress
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Free type aliases should not require all generic parameters to be used
5 participants
@fmease @rust-timer @bors @BoxyUwU @rustbot